Skip to content

Add canonical in-place transformation layer - #2

Merged
TonisOrmisson merged 10 commits into
mainfrom
codex/php-transformation-layer
Jul 31, 2026
Merged

Add canonical in-place transformation layer#2
TonisOrmisson merged 10 commits into
mainfrom
codex/php-transformation-layer

Conversation

@TonisOrmisson

Copy link
Copy Markdown
Contributor

What changed

  • adds a source-neutral canonical TransformationPlan, deterministic serialization/hash, and validation
  • adds an in-place PDO executor for all supported SQL profiles, with Dolt clean-working-set and stable branch/HEAD guards
  • separates the SPSS lexer/parser/AST/binder/compiler under OpenStatSpec\Frontend\Spss
  • adds honest Stata and SAS placeholder boundaries without support claims
  • adds conformance/regression coverage and a transformation manual linked from the README

Architectural guarantees

Successful transformations preserve the same dataset_id and the same physical wide table. OpenStatSpec does not create derived datasets, persistent staging/copy/snapshot/rollback artifacts, or its own version layer. Dolt remains the versioning and rollback layer; it is an additional guarded profile, not a gateway.

The SPSS subset fails closed where semantics are not yet modelled, including user-missing MISSING and case-insensitive catalog symbol binding. String mutations enforce normative declared_string_width before SQL mutation.

Validation

  • independent re-review: no P0/P1 blockers
  • focused PHPUnit: 27 tests, 140 assertions
  • full composer check: 192 tests, 1502 assertions, 13 external-server skips
  • PHPStan: no errors
  • PHP CS Fixer dry-run: clean
  • git diff --check: clean

No tag or release is included in this PR.

@TonisOrmisson
TonisOrmisson marked this pull request as ready for review July 31, 2026 16:24

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 906d5c93c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Transformation/Execution/InPlaceTransformationExecutor.php Outdated
Comment thread src/Transformation/Execution/InPlaceTransformationExecutor.php

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05be2a62cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Transformation/Execution/InPlaceTransformationExecutor.php
Comment thread src/Transformation/Validation/PlanValidator.php Outdated

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 83492f49b7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Frontend/Spss/Binder.php

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 684a3b8ac5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Transformation/Validation/PlanValidator.php Outdated
@TonisOrmisson

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c793476af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Transformation/Execution/InPlaceTransformationExecutor.php
@TonisOrmisson

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96836e2e07

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Transformation/Execution/InPlaceTransformationExecutor.php
Comment thread src/Transformation/Execution/InPlaceTransformationExecutor.php Outdated
@TonisOrmisson

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7e8772e70a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Frontend/Spss/Lexer.php Outdated
Comment thread src/Frontend/Spss/Binder.php
@TonisOrmisson

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 136e09905e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@TonisOrmisson
TonisOrmisson merged commit 83b6329 into main Jul 31, 2026
40 checks passed
@TonisOrmisson
TonisOrmisson deleted the codex/php-transformation-layer branch July 31, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant